[PATCH] D54313: [compiler-rt][builtins][PowerPC] Add floattitf builtin compiler-rt method support for PowerPC

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 3 05:25:07 PST 2019


amyk updated this revision to Diff 180040.
amyk marked 2 inline comments as done.
amyk added a comment.

Updated patch to address:

- renamed variables for names that adhere more to LLVM naming conventions
- changed the low part of the function argument to unsigned, as it will later be passed into a function that expects an unsigned argument
- Removed a temporary that represented 2^64.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54313/new/

https://reviews.llvm.org/D54313

Files:
  compiler-rt/lib/builtins/CMakeLists.txt
  compiler-rt/lib/builtins/ppc/floattitf.c
  compiler-rt/test/builtins/Unit/ppc/floattitf_test.c
  compiler-rt/test/builtins/Unit/ppc/floattitf_test.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54313.180040.patch
Type: text/x-patch
Size: 21558 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190103/98bc996b/attachment.bin>


More information about the llvm-commits mailing list