[PATCH] D56257: Python compat - iteritems

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 3 03:23:56 PST 2019


serge-sans-paille created this revision.
serge-sans-paille added a reviewer: michaelplatings.
Herald added a subscriber: llvm-commits.

Repository:
  rL LLVM

https://reviews.llvm.org/D56257

Files:
  test/tools/llvm-readobj/Inputs/relocs.py
  utils/Reviewing/find_interesting_reviews.py
  utils/docker/scripts/llvm_checksum/llvm_checksum.py


Index: utils/docker/scripts/llvm_checksum/llvm_checksum.py
===================================================================
--- utils/docker/scripts/llvm_checksum/llvm_checksum.py
+++ utils/docker/scripts/llvm_checksum/llvm_checksum.py
@@ -183,7 +183,7 @@
     if len(new_checksums) != len(reference_checksums):
       return False
 
-  for proj, checksum in new_checksums.iteritems():
+  for proj, checksum in new_checksums.items():
     # We never computed a checksum for this project.
     if proj not in reference_checksums:
       return False
Index: utils/Reviewing/find_interesting_reviews.py
===================================================================
--- utils/Reviewing/find_interesting_reviews.py
+++ utils/Reviewing/find_interesting_reviews.py
@@ -52,10 +52,10 @@
         return self.id2PhabObjects[id]
 
     def get_ids_in_cache(self):
-        return self.id2PhabObjects.keys()
+        return list(self.id2PhabObjects.keys())
 
     def get_objects(self):
-        return self.id2PhabObjects.values()
+        return list(self.id2PhabObjects.values())
 
     DEFAULT_DIRECTORY = "PhabObjectCache"
 
Index: test/tools/llvm-readobj/Inputs/relocs.py
===================================================================
--- test/tools/llvm-readobj/Inputs/relocs.py
+++ test/tools/llvm-readobj/Inputs/relocs.py
@@ -75,7 +75,7 @@
     def makeKey(item):
       return (item[1], item[0])
     e = []
-    for pair in sorted(self._nameMap.iteritems(), key=makeKey):
+    for pair in sorted(self._nameMap.items(), key=makeKey):
       e.append(pair)
     return e
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56257.180020.patch
Type: text/x-patch
Size: 1584 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190103/e563ff86/attachment.bin>


More information about the llvm-commits mailing list