[PATCH] D56080: update the pr_datasz of .note.gnu.property section

Vyacheslav Zakharin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 2 21:46:37 PST 2019


vzakhari added inline comments.


================
Comment at: lib/Target/X86/X86AsmPrinter.cpp:577
+      OutStreamer->EmitIntValue(FeatureFlagsAnd, 4); // data
       EmitAlignment(WordSize == 4 ? 2 : 3);                 // padding
 
----------------
Good.  Now everything except this line looks consistent.

If we make members 4-byte values why do we want to keep 8-byte alignment for x86-64?  May I have a link to the proposed ABI change?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56080/new/

https://reviews.llvm.org/D56080





More information about the llvm-commits mailing list