[PATCH] D56235: Teach ObjCARC optimizer about equivalent PHIs when eliminating autoreleaseRV/retainRV pairs

[Akira Hatanaka via Phabricator via llvm-commits]

ahatanak added a comment.

LGTM



================
Comment at: lib/Transforms/ObjCARC/ObjCARCOpts.cpp:613
+    for (const Value *ArgUser : ArgUsers)
+      EquivalentArgs.insert(ArgUser);
+  }
----------------
If you'd like, you can use the insert method that takes the begin and end iterators instead of writing a loop.


================
Comment at: lib/Transforms/ObjCARC/ObjCARCOpts.cpp:625
+    if (GetBasicARCInstKind(&*I) == ARCInstKind::AutoreleaseRV) {
+      if (EquivalentArgs.count(GetArgRCIdentityRoot(&*I))) {
+        Changed = true;
----------------
You can reduce indentation if you use `&&` instead of introducing an if statement here.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56235/new/

https://reviews.llvm.org/D56235