[PATCH] D30526: [Support] Add functions to get and set thread name.

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 2 17:06:32 PST 2019


I'm on vacation right now so I don't have a source tree that I can get
access to, but if the two files are in the same directory then I think we
shouldn't specify the folder name, and it should just be #include
"WindowsSupport.h".  Let me know if I'm misunderstood the situation though.

On Wed, Jan 2, 2019 at 4:17 PM Tom Tan via Phabricator <
reviews at reviews.llvm.org> wrote:

> TomTan added a comment.
> Herald added subscribers: kristina, jfb.
>
> Hi Zachary, does this line "#include "Windows/WindowsSupport.h" " need to
> be changed to "#include "WindowsSupport.h" " after it is moved from
> Threading.cpp to Threading.inc, because Threading.inc which includes
> WindowsSupport.h is under Windows folder, so no need to have it in the
> include path. This current include path could trigger warning "#include
> resolved using non-portable Microsoft search rules as: ..."
>
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D30526/new/
>
> https://reviews.llvm.org/D30526
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190102/1595b45d/attachment.html>


More information about the llvm-commits mailing list