[PATCH] D54720: [PPC64] toc-indirect to toc-relative relaxation.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Arch/PPC64.cpp:110
+  if (Index >= Relas.size()) {
+    warn("invalid offset " + Twine(Offset) + " into the .toc section in " +
+         toString(TocSec->File));
----------------
Isn't this an error?


================
Comment at: ELF/Arch/PPC64.cpp:120
+  if (Offset != Rela.r_offset) {
+    warn("offset mismatch on toc relaxation in " + toString(TocSec->File) +
+         " expected: " + Twine(Offset) + " but found: " + Twine(Rela.r_offset));
----------------
Ditto


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54720/new/

https://reviews.llvm.org/D54720