[PATCH] D56092: [WebAssembly] made assembler parse block_type

[Heejin Ahn via Phabricator via llvm-commits]

aheejin accepted this revision.
aheejin added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.



================
Comment at: lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp:522
+      // Support blocks with no operands as default to void.
+      addBlockTypeOperand(Operands, NameLoc, WebAssembly::ExprType::Void);
     }
----------------
aardappel wrote:
> aheejin wrote:
> > It looks like we assume no signature as void, but all lines in the test case now have type signatures. Can we also have block/loop/try with no signatures?
> I was originally going to require explicitly writing `void`, but the existing code (printWebAssemblySignatureOperand) wasn't printing it, so I decided to follow that.
Yes I agree that we should be able to omit `void`. What I was suggesting was maybe we could add lines that omit `void` in the test case too.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56092/new/

https://reviews.llvm.org/D56092