[PATCH] D56205: Add -z common-page-size option

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 2 14:33:37 PST 2019


ruiu added a comment.

In D56205#1344250 <https://reviews.llvm.org/D56205#1344250>, @christylee wrote:

> > Do you know why that system uses not only max-page-size but also common-page-size?
>
> It looks like they want to align hot text on `common-page-size` but everything else on `max-page-size`.  gold aligns everything to `max-page-size` unless `common-page-size` is specified, I wonder if that's true for lld?


I believe that lld basically aligns everything according to `max-page-size`, which I believe what people expected. Could you elaborate a bit on why hot text (is that .text.hot section?) needs to have a stricter alignment requirement than the common-page-size? I'm asking because all use cases of `common-page-size` I've seen so far is kind of a cargo culting that people were adding the option even though they don't actually need it.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56205/new/

https://reviews.llvm.org/D56205





More information about the llvm-commits mailing list