[llvm] r350260 - [WebAssembly][NFC] Elaborate on simd-noopt test comment

Thomas Lively via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 2 12:43:09 PST 2019


Author: tlively
Date: Wed Jan  2 12:43:08 2019
New Revision: 350260

URL: http://llvm.org/viewvc/llvm-project?rev=350260&view=rev
Log:
[WebAssembly][NFC] Elaborate on simd-noopt test comment

Modified:
    llvm/trunk/test/CodeGen/WebAssembly/simd-noopt.ll

Modified: llvm/trunk/test/CodeGen/WebAssembly/simd-noopt.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/WebAssembly/simd-noopt.ll?rev=350260&r1=350259&r2=350260&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/WebAssembly/simd-noopt.ll (original)
+++ llvm/trunk/test/CodeGen/WebAssembly/simd-noopt.ll Wed Jan  2 12:43:08 2019
@@ -1,14 +1,16 @@
-; RUN: llc < %s -mattr=+simd128,+sign-ext -verify-machineinstrs
+; RUN: llc < %s -fast-isel -mattr=+simd128,+sign-ext -verify-machineinstrs
 
 ;; Ensures fastisel produces valid code when storing and loading split
-;; up v2i64 values. This is a regression test for a bug that crashed
-;; llc after fastisel produced machineinstrs that used registers that
-;; had never been defined.
+;; up v2i64 values. Lowering away v2i64s is a temporary measure while
+;; V8 does not have support for i64x2.* operations, and is done when
+;; -wasm-enable-unimplemented-simd is not present. This is a
+;; regression test for a bug that crashed llc after fastisel produced
+;; machineinstrs that used registers that had never been defined.
 
 target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128"
-target triple = "wasm32-unknown-unknown-wasm"
+target triple = "wasm32-unknown-unknown"
 
-define i64 @foo(<2 x i64> %vec) #0 {
+define i64 @foo(<2 x i64> %vec) {
 entry:
   %vec.addr = alloca <2 x i64>, align 16
   store <2 x i64> %vec, <2 x i64>* %vec.addr, align 16
@@ -16,5 +18,3 @@ entry:
   %1 = extractelement <2 x i64> %0, i32 0
   ret i64 %1
 }
-
-attributes #0 = { noinline optnone }




More information about the llvm-commits mailing list