[PATCH] D55596: Reimplement Thread Static Data ASan routines with TLS

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 2 08:51:18 PST 2019


krytarowski added a comment.

In D55596#1343564 <https://reviews.llvm.org/D55596#1343564>, @ro wrote:

> In D55596#1334312 <https://reviews.llvm.org/D55596#1334312>, @krytarowski wrote:
>
> > @ro could you please test this patch for Solaris? I need to know whether it works with TLS destructor on SunOS.
>
>
> I ran into two compilation failures on unmodified trunk first and got sidetracked (also by the Christmas holidays).  However, after
>  fixing those, applying your patch locally and enabling it on PLATFORM_SOLARIS, it seemed to work fine.


As we cannot switch Linux and get a single implementation for everybody, if you need this patch feel free to switch Solaris to it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55596/new/

https://reviews.llvm.org/D55596





More information about the llvm-commits mailing list