[PATCH] D55975: [X86] Remove x86ISD::INC/DEC. Just select them from X86ISD::ADD/SUB at isel time

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 2 07:35:36 PST 2019


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Target/X86/X86ISelLowering.cpp:18660
+    // flags if there is a reasonable chance of either using that to do custom
+    // instructions selection that can fold some of the memory operands, or if
+    // only the flags are used. If there are other uses, leave the node alone
----------------
instructions selection -> instruction selection ?
This is an awkward/long sentence, so it might be better to just edit:
  // Transform to an x86-specific ALU node with flags if there is a chance of
  // folding a memory operand or only the flags are used. Otherwise, leave 
  // the node alone and emit a 'test' instruction.



Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55975/new/

https://reviews.llvm.org/D55975





More information about the llvm-commits mailing list