[PATCH] D56123: [llvm-objdump] - Print symbol addressed when dumping disassembly output (-d)

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM too. Not that I'm saying you should change it, as I don't know how complex it would be, but perhaps an alternative to consider might have been to disassemble the first zeroes after a symbol, even without -z. Something like this:

  foo:
  10: 00 00
  ...
  bar:
  40: 00 00
  ...

I'm not sure how desirable that is versus the alternative though (really, I'm not sure I see much benefit to the behaviour of not disassembling zeroes, but that's just me).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56123/new/

https://reviews.llvm.org/D56123