[PATCH] D56076: [llvm-objdump] - Do not include reserved undefined symbol in -t output.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with a couple of nits.



================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:1977
+  for (auto I = o->symbol_begin(), E = o->symbol_end(); I != E; ++I) {
+    // Skip printing the special zero symbol when dumping ELF file.
+    // This makes output to be consistent with the GNU objdump.
----------------
dumping ELF -> dumping an ELF


================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:1978
+    // Skip printing the special zero symbol when dumping ELF file.
+    // This makes output to be consistent with the GNU objdump.
+    if (I == o->symbol_begin() && isa<ELFObjectFileBase>(o))
----------------
output to be -> the output


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56076/new/

https://reviews.llvm.org/D56076