[PATCH] D56185: [BDCE] Remove intructions without demanded bits

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: test/Transforms/BDCE/invalidate-assumptions.ll:88
 ; CHECK-LABEL: @PR34179(
-; CHECK-NEXT:    [[T0:%.*]] = load volatile i32, i32* %a
+; CHECK-NEXT:    [[T0:%.*]] = load volatile i32, i32* [[A:%.*]]
 ; CHECK-NEXT:    ret void
----------------
nikic wrote:
> lebedev.ri wrote:
> > Can you please do a NFC regen commit first?
> I'm wondering if I should maybe just manually edit those changes away? Using a pattern for an argument name doesn't make a lot of sense to me. Is there a reason why update_test_checks.py generates it this way? Is this so the result looks for uniform?
`[[A:%.*]]` means "match `%.*` regex, and store it to `A`".
So when `[[A]]` is encountered next, it will be expanded to what was previously matched, which is `%a`.
And no, consistently using these update tools is the only sane way.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56185/new/

https://reviews.llvm.org/D56185