[PATCH] D56140: [llvm-readobj] [COFF] Print the symbol index for relocations

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: tools/llvm-readobj/COFFDumper.cpp:1381
     W.printString("Symbol", SymbolName.empty() ? "-" : SymbolName);
+    W.printNumber("SymbolIndex", SymbolIndex);
   } else {
----------------
one minor concern: if I understand correctly if the symbol is not found (Symbol == Obj->symbol_end()) this code still will print SymbolIndex = 0. Maybe we can do smth similar to how SymbolName is handled ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56140/new/

https://reviews.llvm.org/D56140