[PATCH] D56180: Replace gen_dynamic_list.py with a portable shell script

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 31 21:40:06 PST 2018


krytarowski marked an inline comment as done.
krytarowski added a comment.

Does this work and produce exactly the same result on Linux (.syms content) with the original .py script and the .sh version?



================
Comment at: lib/sanitizer_common/scripts/gen_dynamic_list.sh:50
+
+my_nm=${NM:-nm}
+my_awk=${AWK:-awk}
----------------
mgorny wrote:
> Why not
> 
>     : "${NM:=nm}"
> 
> ?
`:=` would be needed if `nm` could be expanded to something, we probably don't need it property.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56180/new/

https://reviews.llvm.org/D56180





More information about the llvm-commits mailing list