[PATCH] D56011: [x86] lower extracted fadd/fsub to horizontal vector math

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 31 09:31:09 PST 2018


spatel marked an inline comment as done.
spatel added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:18324
+  return !IsSingleSource || IsOptimizingSize || HasFastHOps;
+}
+
----------------
RKSimon wrote:
> We already have shouldCombineToHorizontalOp 
Right - I’m moving/renaming it here because it’s used in both combining and lowering after this patch. I can make that an NFC pre-commit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56011/new/

https://reviews.llvm.org/D56011





More information about the llvm-commits mailing list