[PATCH] D55992: [ARM] Add missing patterns for DSP muls

Mon Dec 31 07:25:43 PST 2018

samparker updated this revision to Diff 179761.
samparker added a comment.

Hi Eli,

Thanks for taking a look. Yes, the operands can be commuted and it's why the tests accept top-bottom and bottom-top muls in those tests. I've now also added a few extra tests with swapped operands.

I've tried to combine these patterns before into something nicer, without luck and again I've tried and failed... The errors given by tablegen leave me baffled: I seem to be hitting a problem using 'PatFrags' matching a 'PatFrag' and a 'PatLeaf' and also some kind of type errors that I haven't seen before! However, I have created some PatFrags for the muls to simplify the descriptions.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55992/new/

https://reviews.llvm.org/D55992

Files:
  lib/Target/ARM/ARMInstrInfo.td
  lib/Target/ARM/ARMInstrThumb2.td
  test/CodeGen/ARM/smul.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55992.179761.patch
Type: text/x-patch
Size: 23137 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181231/bbbfc6cc/attachment.bin>