[PATCH] D56152: [sanitizer_common] Add tests for remaining *putc and *getc variants

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 29 14:31:00 PST 2018


krytarowski accepted this revision.
krytarowski added a comment.
This revision is now accepted and ready to land.

In D56152#1342372 <https://reviews.llvm.org/D56152#1342372>, @mgorny wrote:

> In D56152#1342331 <https://reviews.llvm.org/D56152#1342331>, @krytarowski wrote:
>
> > Are all the functions available for FreeBSD, NetBSD, Linux, Android, Solaris an Darwin?
>
>
> I don't know. I suppose the easiest way to check would be to commit it and see what happens. Then address the fallout.
>
> > I would include a test for `getchar_unlocked()` anyway, even if it's an alias in most/all implementations.
>
> I suppose I could do that but I'd have to pipe some data into the stdin.


OK, so let's do it in another test.

Please drop its mention in description.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56152/new/

https://reviews.llvm.org/D56152





More information about the llvm-commits mailing list