[PATCH] D56119: [PowerPC] Fix ADDE, SUBE do not know how to promote operator

Zhang Kang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 29 05:54:06 PST 2018


ZhangKang marked 2 inline comments as done.
ZhangKang added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:871
+// Handle promotion for the ADDE/SUBE/ADDCARRY/SUBCARRY nodes. Notice that
+// the third operand of ADDE/SUBE noes is carry flag, which differs from 
+// the ADDCARRY/SUBCARRY nodes in that the third operand is carry Boolean.
----------------
jsji wrote:
> typo: noes -> nodes
Done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56119/new/

https://reviews.llvm.org/D56119





More information about the llvm-commits mailing list