[PATCH] D56098: [ARM] Teach ComputeKnownBitsTarget to handle extract vectors

silviu.baranga@arm.com via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 28 08:42:26 PST 2018


sbaranga added inline comments.


================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:13643
+    ConstantSDNode *Pos = dyn_cast<ConstantSDNode>(Op.getOperand(1).getNode());
+    if (Pos && Pos->getAPIntValue().ult(NumSrcElts)) {
+      // If we know the element index, just demand that vector element.
----------------
I think this test should always evaluate to true. Maybe it should be an assert?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56098/new/

https://reviews.llvm.org/D56098





More information about the llvm-commits mailing list