[PATCH] D56130: Extend Module::getOrInsertGlobal to also take the default arguments accepted by the GlobalVariable constructor.

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 28 08:14:40 PST 2018


compnerd added a comment.

I'm not sure how I feel about the additional parameters.  What do you think about packaging up the filters into a structure and passing a single "blob" as the filter?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56130/new/

https://reviews.llvm.org/D56130





More information about the llvm-commits mailing list