[PATCH] D56125: [Sanitizer] Intercept arc4random_buf on FreeBSD/NetBSD

David CARLIER via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 28 05:32:17 PST 2018


devnexen marked an inline comment as done.
devnexen added inline comments.


================
Comment at: test/sanitizer_common/TestCases/Posix/arc4random.cc:15
+
+  arc4random_buf(buf, sizeof(buf));
+  return 0;
----------------
krytarowski wrote:
> Please print buf.
> 
> ```
> printf("buf: '");
> for (size_t i = 0; i < sizeof buf; i++)
>   printf("%" PRIx8, buf[i]);
> printf("'\n");
> ```
> 
> and
> 
> `CHECK: buf '{{.*}}`
Good point.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56125/new/

https://reviews.llvm.org/D56125





More information about the llvm-commits mailing list