[PATCH] D54016: [X86] don't allow X86_64 PIC mode addresses to be used as immediates

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 27 11:31:52 PST 2018


rnk requested changes to this revision.
rnk added a comment.
This revision now requires changes to proceed.

It looks like this was actually intentionally removed back in rL107727 <https://reviews.llvm.org/rL107727> to fix https://llvm.org/pr4752. This change breaks the test that was added for it, `llvm/test/CodeGen/X86/2010-07-06-asm-RIP.ll`. I guess, since this is GCC inline asm, the question is, how does GCC handle the 'i' constraint? I suspect that this new behavior may be closer to GCC, but it'll require more analysis.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54016/new/

https://reviews.llvm.org/D54016





More information about the llvm-commits mailing list