[PATCH] D56089: [ELF] A shared object is needed if any of its occurrences is needed

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 27 10:13:22 PST 2018


ruiu added a comment.

I'm still a bit hesitant about doing this, but perhaps it is better to accept this because without this a mysterious runtime error could happen as you explained. But I wonder if you can simplify it even more. Can you do something like this? I didn't test this but I think we don't need a hash table.

https://gist.github.com/rui314/92fdae6c0678528e76ad1a5e8818a57f


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56089/new/

https://reviews.llvm.org/D56089





More information about the llvm-commits mailing list