[PATCH] D55686: [PowerPC] Fix assert from machine verify pass that unmatched register class about fcmp selection in fast-isel

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 27 09:12:06 PST 2018


hfinkel added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCFastISel.cpp:900
       } else
-        CmpOpc = PPC::FCMPUD;
+        CmpOpc = PPCSubTarget->hasVSX() ? PPC::XSCMPUDP : PPC::FCMPUD;
       break;
----------------
This would be the only place I see here where we're checking hasVSX(). Should we call getRegForValue earlier and then use isVSFRCRegClass? Do we need to do the same thing about with isVSSRCRegClass and PPC::FCMPUS?



Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55686/new/

https://reviews.llvm.org/D55686





More information about the llvm-commits mailing list