[PATCH] D56083: [llvm-objdump] - Implement -z/--disassemble-zeroes

[George Rimar via Phabricator via llvm-commits]

grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: test/ELF/mips-26.s:9
 # RUN: ld.lld %t1.o %t.so -o %t.exe
-# RUN: llvm-objdump -d %t.exe | FileCheck %s
+# RUN: llvm-objdump -d -z %t.exe | FileCheck %s
 # RUN: llvm-readobj -dynamic-table -s -r -mips-plt-got %t.exe \
----------------
atanasyan wrote:
> Output of `llvm-objdump` without `-z` option for at least this test case looks strange:
> ```
> __start:
>    20008:       0c 00 80 00     jal     131072 <bar>
>    2000c:       00 00 00 00     nop
>    20010:       0c 00 80 10     jal     131136 <foo0+0x20040>
>                 ...
>    20018:       00 00 00 00     nop
> 
> loc:
>    20018:       00 00 00 00     nop
> ```
> 
> We skip the first `nop` at 20014 offset, but show `nop` at 20018 twice. I apply the patch at r350033.
I knew this skips the nops in this test because they are encoded as zero bytes for mips, but did not notice it shows the same offset twice. Will recheck it, thanks for looking!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56083/new/

https://reviews.llvm.org/D56083