[lld] r350036 - Tolerate flaky LLD tests on NetBSD

Kamil Rytarowski via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 23 13:20:09 PST 2018


Author: kamil
Date: Sun Dec 23 13:20:09 2018
New Revision: 350036

URL: http://llvm.org/viewvc/llvm-project?rev=350036&view=rev
Log:
Tolerate flaky LLD tests on NetBSD

Summary:
For unknown reasons  LLD tests are flaky on the NetBSD buildbot,
but not on local machines of developers.

Unless the linker will be fully functional on this target,
allow to pass flaky tests with optional retry.

Reviewers: joerg, mgorny, ruiu

Reviewed By: mgorny

Subscribers: lebedev.ri, MaskRay, llvm-commits, #lld

Tags: #lld

Differential Revision: https://reviews.llvm.org/D56053

Modified:
    lld/trunk/test/lit.cfg.py

Modified: lld/trunk/test/lit.cfg.py
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/lit.cfg.py?rev=350036&r1=350035&r2=350036&view=diff
==============================================================================
--- lld/trunk/test/lit.cfg.py (original)
+++ lld/trunk/test/lit.cfg.py Sun Dec 23 13:20:09 2018
@@ -45,6 +45,11 @@ tool_patterns = [
 
 llvm_config.add_tool_substitutions(tool_patterns)
 
+# LLD tests tend to be flaky on NetBSD, so add some retries.
+# We don't do this on other platforms because it's slower.
+if platform.system() in ['NetBSD']:
+    config.test_retry_attempts = 2
+
 # When running under valgrind, we mangle '-vg' onto the end of the triple so we
 # can check it with XFAIL and XTARGET.
 if lit_config.useValgrind:




More information about the llvm-commits mailing list