[PATCH] D56057: [X86] Individually simplify both operands of PMULDQ/PMULUDQ using the other entry point of SimplifyDemandedBits that allows the one use check of the root node to be suppressed.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 22 21:57:49 PST 2018


craig.topper created this revision.
craig.topper added reviewers: RKSimon, spatel.

This entry point takes special care to avoid completely replacing the root node if it has multiple uses. Instead it will just use UpdateNodeOperands to only update the PMULDQ/PMULUDQ node. Not sure if that can create additional instructions in some cases.

This allows masking and sign_extend_inreg opcodes to be removed from the input of these operations.

Fixes PR40142.


Repository:
  rL LLVM

https://reviews.llvm.org/D56057

Files:
  lib/Target/X86/X86ISelLowering.cpp
  test/CodeGen/X86/avx2-intrinsics-fast-isel.ll
  test/CodeGen/X86/avx512-intrinsics-fast-isel.ll
  test/CodeGen/X86/pmul.ll
  test/CodeGen/X86/sse2-intrinsics-fast-isel.ll
  test/CodeGen/X86/sse41-intrinsics-fast-isel.ll
  test/CodeGen/X86/vector-mul.ll
  test/CodeGen/X86/vector-reduce-mul-widen.ll
  test/CodeGen/X86/vector-reduce-mul.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56057.179435.patch
Type: text/x-patch
Size: 62171 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181223/2b97f4a0/attachment.bin>


More information about the llvm-commits mailing list