[PATCH] D56053: Tolerate flaky LLD tests on NetBSD

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 22 11:33:08 PST 2018


krytarowski created this revision.
krytarowski added reviewers: joerg, mgorny, ruiu.
krytarowski added a project: lld.
Herald added subscribers: llvm-commits, MaskRay.

For unknown reasons  LLD tests are flaky on the NetBSD buildbot,
but not on local machines of developers.

Unless the linker will be fully functional on this target,
allow to pass flaky tests with optional retry.


Repository:
  rL LLVM

https://reviews.llvm.org/D56053

Files:
  test/lit.cfg.py


Index: test/lit.cfg.py
===================================================================
--- test/lit.cfg.py
+++ test/lit.cfg.py
@@ -45,6 +45,11 @@
 
 llvm_config.add_tool_substitutions(tool_patterns)
 
+# LLD tests tend to be flaky on NetBSD, so add some retries.
+# We don't do this on other platforms because it's slower.
+if platform.system() == 'NetBSD':
+    config.test_retry_attempts = 2
+
 # When running under valgrind, we mangle '-vg' onto the end of the triple so we
 # can check it with XFAIL and XTARGET.
 if lit_config.useValgrind:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56053.179430.patch
Type: text/x-patch
Size: 549 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181222/9e6c4e7e/attachment.bin>


More information about the llvm-commits mailing list