[PATCH] D55075: [TSan] Remove ignore_interceptors_accesses flag

[Dmitry Vyukov via Phabricator via llvm-commits]

dvyukov accepted this revision.
dvyukov added inline comments.


================
Comment at: compiler-rt/test/tsan/ignored-interceptors-mmap.cc:53
+
+  assert(global_p[0] == 7);
   printf("OK\n");
----------------
yln wrote:
> dvyukov wrote:
> > Are asserts even enabled in all builds? I would just use if.
> > 
> This is not a test assert/check but rather an assert to ensure the sanity of the test itself.
> The actual test checks are below (the FileCheck directives). Note both expect "OK", i.e., the program completes and not aborted via the assert. So I am not too sure would you would put into the if?
> Let me know if you have an idea how to better express my intent here.
OK, I see assert is used in other tests. So let's leave it.
There is usually no difference between thing-under-test failing, or the test itself failing -- in both cases the test needs to fail and a human needs to take a look. A filecheck failure can indicate both as well for most of our tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55075/new/

https://reviews.llvm.org/D55075