[PATCH] D54498: AbstractCallSite -- A unified interface for (in)direct and callback calls

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 21 14:21:36 PST 2018


hfinkel added a comment.

> I can certainly split this into more patches if that is preferred. I'm unsure though how to test the metadata and abstract call sites without a user.

While not strictly necessary in my book (given that the patch would be committed with its first user which would have tests), unit tests are probably a good idea (i.e., put something in the unittests/IR/ directory).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54498/new/

https://reviews.llvm.org/D54498





More information about the llvm-commits mailing list