[PATCH] D55971: [ELF] .gnu.hash bloom filter: use Shift2 = 26 instead of 6

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 21 13:17:29 PST 2018


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/SyntheticSections.cpp:2180
+    // When C = 64, we choose a word with bits [6:...] and set 1 to two bits in
+    // the word using bits [0:5] and [26:31]. It is important to be independent.
     size_t I = (Sym.Hash / C) & (MaskWords - 1);
----------------
"It is important to be independent." is a bit too vague or too obvious. I'd just remove that sentence.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55971/new/

https://reviews.llvm.org/D55971





More information about the llvm-commits mailing list