[PATCH] D55967: [CodeExtractor] Do not extract unsafe lifetime markers

[Sergei Kachkov via Phabricator via llvm-commits]

kachkov98 added a comment.

I'm concerned about skipping processing markers for outputs. Currently HotColdSplit and partial inlining do not outline function if number of outputs  is not zero (by calling findInputsOutputs()),  but this check is unreliable because there is some processing of region before extracting (splitReturnBlocks, splitPHINodesOfEntry, splitPHINodesOfExit) and input/output parameters can be changed (their number may become non-zero). So another question is why this check should be done at all (does it bypass some known problem?) Seems that CodeExtractor does not impose such restrictions.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55967/new/

https://reviews.llvm.org/D55967