[PATCH] D56013: [ELF] Use SymbolTable::ComdatGroups instead of DummyGroups in LTO

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 21 11:03:24 PST 2018


pcc added a comment.

Yes, unless you're guaranteed that none of the object files will contain any comdats (and I don't believe that the backend makes anything near this guarantee right now), you're going to end up dropping "real" definitions on the floor with this.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56013/new/

https://reviews.llvm.org/D56013





More information about the llvm-commits mailing list