[PATCH] D54749: Saturating float to int casts: Basics [1/n]

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D54749#1339117 <https://reviews.llvm.org/D54749#1339117>, @nikic wrote:

> In D54749#1329486 <https://reviews.llvm.org/D54749#1329486>, @t.p.northover wrote:
>
> > I think the consistency argument is good, so I'm in favour of the structure you chose now. My main issue at the moment is the tests: hard-coding register usage leads to very fragile tests.
>
>
> Is there any way to avoid hardcoded register usage in an automated manner?


>From previous discussions, the hardcoded/spelled-out register names are intentional.

> With vector coverage, this is probably going to need about 15k lines of tests just for two platforms, and they're going to change quite a bit until codegen is finalized. I don't think it's productive to write and rewrite those by hand.

+1, `update_llc_test_checks.py` is the standard tool for the task, and is the only sane way to have meaningful, reasonable test coverage without going insane from having to write `CHECK` lines by hand.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54749/new/

https://reviews.llvm.org/D54749