[PATCH] D55921: [AArch64] Add command-line option for SB

Oliver Stannard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 21 02:47:18 PST 2018


olista01 added inline comments.


================
Comment at: lib/Target/AArch64/AArch64.td:309
 
+def FeatureSB : SubtargetFeature<"sb", "HasSB",
+  "true", "Enable v8.5 Speculation Barrier" >;
----------------
I don't think this is needed. You've moved the SB instruction from FeatureSpecCtrl to this new feature, but the SB instruction was the only thing in FeatureSpecCtrl, which is now empty.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55921/new/

https://reviews.llvm.org/D55921





More information about the llvm-commits mailing list