[PATCH] D54732: [LoopUnroll] Don't verify domtree by default with +Asserts.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 20 17:32:10 PST 2018


This revision was automatically updated to reflect the committed changes.
Closed by commit rL349871: [LoopUnroll] Don't verify domtree by default with +Asserts. (authored by efriedma, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D54732?vs=174699&id=179210#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54732/new/

https://reviews.llvm.org/D54732

Files:
  llvm/trunk/lib/Transforms/Utils/LoopUnroll.cpp
  llvm/trunk/lib/Transforms/Utils/LoopUnrollPeel.cpp


Index: llvm/trunk/lib/Transforms/Utils/LoopUnrollPeel.cpp
===================================================================
--- llvm/trunk/lib/Transforms/Utils/LoopUnrollPeel.cpp
+++ llvm/trunk/lib/Transforms/Utils/LoopUnrollPeel.cpp
@@ -615,7 +615,9 @@
       // the original loop body.
       if (Iter == 0)
         DT->changeImmediateDominator(Exit, cast<BasicBlock>(LVMap[Latch]));
+#ifdef EXPENSIVE_CHECKS
       assert(DT->verify(DominatorTree::VerificationLevel::Fast));
+#endif
     }
 
     auto *LatchBRCopy = cast<BranchInst>(VMap[LatchBR]);
Index: llvm/trunk/lib/Transforms/Utils/LoopUnroll.cpp
===================================================================
--- llvm/trunk/lib/Transforms/Utils/LoopUnroll.cpp
+++ llvm/trunk/lib/Transforms/Utils/LoopUnroll.cpp
@@ -54,10 +54,10 @@
 static cl::opt<bool>
 UnrollVerifyDomtree("unroll-verify-domtree", cl::Hidden,
                     cl::desc("Verify domtree after unrolling"),
-#ifdef NDEBUG
-    cl::init(false)
-#else
+#ifdef EXPENSIVE_CHECKS
     cl::init(true)
+#else
+    cl::init(false)
 #endif
                     );
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54732.179210.patch
Type: text/x-patch
Size: 1095 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181221/761cc531/attachment.bin>


More information about the llvm-commits mailing list