[PATCH] D55969: [BasicAA] Fix AA bug on dynamic allocas and stackrestore

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

My experience so far with inalloca has been that, no, those passes are not safe. This is only the latest in a long line of bugs in LLVM around handling dynamic allocas. I think conflating static and dynamic allocas was a mistake, and we would've been better served with a separate construct for allocating stack memory for local variables, but at this stage, we'd be better off standardizing on the terminology of "alloca" for standard locals and pushing dynamic allocas into intrinsic instructions.

I'd like to do the same for inalloca, and use tokens to establish a region around the call site. I started a design doc for it, but it looks like I deleted it at some point. :(


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55969/new/

https://reviews.llvm.org/D55969