[PATCH] D51362: [GlobalISel][IRTranslator] Canonicalize G_ICMP to have constant operands last

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 20 17:09:47 PST 2018


qcolombet added a comment.

I still believe we shouldn't do that here and more generally O0 should be kept out of doing things on the code.

My main concern is if we allow this kind of combine here, where do we draw the line for future combines?
Thus, I would rather keep this pass dumb and bite the bullet at O0.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D51362/new/

https://reviews.llvm.org/D51362





More information about the llvm-commits mailing list