[PATCH] D54674: [llvm-objcopy] First bits for MachO

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap marked an inline comment as done.
alexshap added inline comments.


================
Comment at: tools/llvm-objcopy/MachO/Reader.cpp:84
+    if (!SecRef)
+      reportError(MachOObj.getFileName(), SecRef.takeError());
+    
----------------
jakehehrlich wrote:
> I should have checked the COFF code for this sort of issue a bit more than I did but I'd like to avoid this where possible. Failing on the first sign of error will slow the pace at which we can convert this into a library which is a long term plan I'd like to see become a reality.
ok, I will change this code (and the same stuff below) & update the diff.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54674/new/

https://reviews.llvm.org/D54674