[PATCH] D55959: [TSan] Enable detection of lock-order-inversions for Objective-C @synchronized

Kuba (Brecka) Mracek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 20 15:18:59 PST 2018


kubamracek added a comment.

LGTM with a nit. @dvyukov are we using the Mutex* calls correctly here?



================
Comment at: compiler-rt/lib/tsan/rtl/tsan_interceptors_mac.cc:322
+// Defined in <objc-sync.h>
+#define OBJC_SYNC_SUCCESS 0
+
----------------
Can we just `#include <objc-sync.h>` instead?


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55959/new/

https://reviews.llvm.org/D55959





More information about the llvm-commits mailing list