[PATCH] D55956: [WebAssembly] Fix invalid machine instrs in -O0, verify in tests

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 20 14:53:07 PST 2018


aheejin added inline comments.


================
Comment at: test/CodeGen/WebAssembly/simd-noopt.ll:9
+
+define i64 @foo(<2 x i64> %vec) #0 {
+entry:
----------------
tlively wrote:
> aheejin wrote:
> > No check lines?
> I'm mostly just interested in this not crashing, but would be happy to add some if you think it would be better.
Not crashing meaning, not crashing llvm regression test or V8? If you mean the latter, I guess it's better to check that v2i64 types are not generated by one or two `CHECK-NOT` lines.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55956/new/

https://reviews.llvm.org/D55956





More information about the llvm-commits mailing list