[PATCH] D55909: [ARMISelLowering] Recompute liveins after introducing new MBBs.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 20 13:27:23 PST 2018


fhahn added a comment.

In D55909#1338092 <https://reviews.llvm.org/D55909#1338092>, @efriedma wrote:

> The interesting constraint here is that ExpandISelPesudos runs immediately after ISel.  And if you have an instruction which produces physical registers from an allocatable register class, ISel will COPY the values to virtual registers immediately after that instruction (and similarly for instructions that consume physical registers).  So in practice, on ARM, the only physical register with a non-trivial live interval in ExpandISelPesudos is CPSR.
>
> Granted, that's a bit fragile, and it isn't formally enforced anywhere.


Thanks Eli, I guess we can just go with only handling CPSR. I will update the patch!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55909/new/

https://reviews.llvm.org/D55909





More information about the llvm-commits mailing list