[llvm] r349808 - [llvm-objcopy] [COFF] Don't call memcpy() with a null argument. NFC.

Martin Storsjo via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 20 11:48:39 PST 2018


Author: mstorsjo
Date: Thu Dec 20 11:48:39 2018
New Revision: 349808

URL: http://llvm.org/viewvc/llvm-project?rev=349808&view=rev
Log:
[llvm-objcopy] [COFF] Don't call memcpy() with a null argument. NFC.

It is invalid to call memcpy with a null pointer, even if the size
is zero.

This should fix the sanitizer buildbot.

Modified:
    llvm/trunk/tools/llvm-objcopy/COFF/Writer.cpp

Modified: llvm/trunk/tools/llvm-objcopy/COFF/Writer.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objcopy/COFF/Writer.cpp?rev=349808&r1=349807&r2=349808&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-objcopy/COFF/Writer.cpp (original)
+++ llvm/trunk/tools/llvm-objcopy/COFF/Writer.cpp Thu Dec 20 11:48:39 2018
@@ -225,7 +225,8 @@ void COFFWriter::writeSections() {
              S.Header.SizeOfRawData - S.Contents.size());
 
     Ptr += S.Header.SizeOfRawData;
-    memcpy(Ptr, S.Relocs.data(), S.Relocs.size() * sizeof(coff_relocation));
+    if (!S.Relocs.empty())
+      memcpy(Ptr, S.Relocs.data(), S.Relocs.size() * sizeof(coff_relocation));
   }
 }
 




More information about the llvm-commits mailing list