[PATCH] D55852: [elfabi] Add support for reading DT_NEEDED from binaries

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: llvm/tools/llvm-elfabi/ELFObjHandler.cpp:126
+  for (uint64_t NeededStrOffset : DynEnt.NeededLibNames) {
+    DestStub->NeededLibs.push_back(std::string(DynStrPtr + NeededStrOffset));
+  }
----------------
nit: I believe you don't need `std::string` as std::string has an implicit constructor from `const char *`.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55852/new/

https://reviews.llvm.org/D55852