[PATCH] D28234: Support for custom install dirs in CMake build

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 20 02:50:21 PST 2018


krytarowski added a comment.

In D28234#1337321 <https://reviews.llvm.org/D28234#1337321>, @nalimilan wrote:

> Given that the PR works as-is and doesn't add too much code, I don't really see the advantage of moving to an "ugly" solution just to use GNUInstallDirs. Is there a strong advantage to that?


Please do use GNUInstallDirs. This way it will be compatible with all cmake users beyond few tested targets and it will be easy to tweak using standard cmake options.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D28234/new/

https://reviews.llvm.org/D28234





More information about the llvm-commits mailing list