[PATCH] D52922: AMDGPU/GlobalISel: Move SMRD selection logic to TableGen

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 19 21:28:33 PST 2018


arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/SMInstructions.td:689-690
+  let GISelPredicateCode = [{
+    if (!MI.hasOneMemOperand())
+      return false;
+    if (!isInstrUniform(MI))
----------------
This isn't necessary since the verifier enforces there is always one MMO for g_load


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52922/new/

https://reviews.llvm.org/D52922





More information about the llvm-commits mailing list