[PATCH] D55902: [ELF] SymbolTable::addShared: don't set IsNeeded unless IsUsedInRegularObj

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/SymbolTable.cpp:504
                                 Alignment, VerdefIndex);
     if (!WasInserted) {
       S->Binding = Binding;
----------------
This part of the logic seems a bit unnecessarily complicated (though I believe I wrote this.) Let's simplify this first.



Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55902/new/

https://reviews.llvm.org/D55902