[PATCH] D55881: [llvm-objcopy] [COFF] Add support for removing symbols and sections

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 19 14:15:46 PST 2018


jakehehrlich added a comment.

One broad comment is that we should probably implement these in different patches. Just pick one for now and we can build up to the others.



================
Comment at: tools/llvm-objcopy/COFF/COFFObjcopy.cpp:56
+
+  if (Config.StripAllGNU || Config.StripDebug || Config.StripAll ||
+      Config.DiscardAll || Config.StripUnneeded) {
----------------
Do these really all do the same thing?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55881/new/

https://reviews.llvm.org/D55881





More information about the llvm-commits mailing list